Avoid test race condition #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a few tests the server's socket is not fully "conditioned" when the client and server threads start. The server tries to finish socket setup, but this races against the client thread sending the message, which may be processed by the kernel with default socket options (observed intermittently in tests on FreeBSD). A more complete solution would be to provide setup hooks for the server setup initialisation, so that the threads don't start until the server socket is ready. Ideally the socket options can be set before the server socket is "bound", ensuring that no messages can come in too early. This is not presently warranted, but perhaps some day...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few tests the server's socket is not fully "conditioned" when the client
and server threads start. The server tries to finish socket setup, but this
races against the client thread sending the message, which may be processed by
the kernel with default socket options (observed intermittently in tests on
FreeBSD).
A more complete solution would be to provide setup hooks for the server
setup initialisation, so that the threads don't start until the server
socket is ready. Ideally the socket options can be set before the
server socket is "bound", ensuring that no messages can come in too
early. This is not presently warranted, but perhaps some day...